[15.0][FIX] account_reconciliation_widget: only stop up down key events #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the previous commit (311a0fa) users couldn't use the tab key to navigate over manual item fields. TT45219
|
Shouldn't this be an allowed list instead. I think I can press other keys like left and right cursors, or characters, and they should be passed upstream? |
|
Well, this is only for these two navigation cases which are the ones that overlap with the general navigation events of the widget. So it should be read like: "Inside the widget when you're in a relational field and press up or down, do the usual stuff with relational fields, otherwise let's navigate the reconciliation items". |
pedrobaeza
approved these changes
Nov 2, 2023
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at fe77211. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-fix-account_reconciliation_widget-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the previous commit (311a0fa) users couldn't use the tab key to navigate over manual item fields.
cc @Tecnativa TT45219
please review @pedrobaeza @victoralmau