Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavbarDropdownMenu on small devices, design update #10

Merged
merged 16 commits into from
May 16, 2024
Merged

NavbarDropdownMenu on small devices, design update #10

merged 16 commits into from
May 16, 2024

Conversation

Fermatka
Copy link
Collaborator

@Fermatka Fermatka self-assigned this May 15, 2024
@Fermatka Fermatka requested a review from roszcz May 15, 2024 18:32
TheMankel
TheMankel reviewed May 16, 2024
View reviewed changes
Copy link

@TheMankel TheMankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I discovered that when we close the menu, the content jumps to the top. I applied a slower transition to capture this in the video:

JumpingMenu.mp4

@Fermatka Fermatka merged commit bc36942 into develop May 16, 2024
1 check passed
@Fermatka Fermatka deleted the PROLL-287/Navbar_Dropdown_Menu branch May 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMankel TheMankel TheMankel approved these changes

@roszcz roszcz roszcz approved these changes

@HolaAleksandra HolaAleksandra Awaiting requested review from HolaAleksandra

Assignees

@Fermatka Fermatka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fermatka @roszcz @TheMankel