ADBMS Integration #138
ADBMS Integration #138
Conversation
…ed on pulling voltages
| int DataIdx; | ||
|
|
||
| for (DataIdx = 0; DataIdx < len; DataIdx++) { | ||
| __io_putchar( *ptr++ ); |
There was a problem hiding this comment.
messed up diff this stuff was changed on main??
There was a problem hiding this comment.
I changed this cuz printing was broken and i think it was cuz of the usart dma changes.
There was a problem hiding this comment.
hmm did u use \r? Also make sure to use ner serial or else it wont work.
Core/Inc/bmsConfig.h
Outdated
| #define NUM_CELLS_PER_CHIP 10 | ||
| #define NUM_SEGMENTS 1 | ||
| #define NUM_CHIPS 1 //NUM_SEGMENTS * 2 | ||
| #define NUM_CELLS_PER_CHIP 16 | ||
| #define NUM_THERMS_PER_CHIP 32 | ||
| #define NUM_RELEVANT_THERMS 3 |
There was a problem hiding this comment.
Its the number of therms that we actually wanted to read on a segment. I think we'll be getting rid of this but i think its outside the scope of this.
Core/Src/segment.c
Outdated
| #define TOTAL_IC 1 | ||
| cell_asic IC[TOTAL_IC]; | ||
|
|
||
| RD REDUNDANT_MEASUREMENT = RD_OFF; |
There was a problem hiding this comment.
we do want redundant in final rev
There was a problem hiding this comment.
Sure we can do that later. I want a full spec from BMS team on exactly what the configs should be and how they want the BMS to work
Core/Src/segment.c
Outdated
| cell_asic IC[TOTAL_IC]; | ||
|
|
||
| RD REDUNDANT_MEASUREMENT = RD_OFF; | ||
| CH AUX_CH_TO_CONVERT = AUX_ALL; |
There was a problem hiding this comment.
we need to setup which AUX channel is read by which multiplexer. The mtg notes I think say the main multiplexer reads internal register and the AUX is dedicated to the GPIOs.
There was a problem hiding this comment.
These variables won't make it into the final draft. this was copied over from adbms source.
There was a problem hiding this comment.
They'll be gone once this code is tested.
| void get_c_adc_voltages(cell_asic *chip) | ||
| { | ||
| wake_and_write_configs(chip); | ||
| adbms_wake(); |
There was a problem hiding this comment.
thats just what worked in testing
| int DataIdx; | ||
|
|
||
| for (DataIdx = 0; DataIdx < len; DataIdx++) { | ||
| __io_putchar( *ptr++ ); |
There was a problem hiding this comment.
hmm did u use \r? Also make sure to use ner serial or else it wont work.
Core/Src/segment.c
Outdated
| } | ||
| // TODO: Its kind of silly to just copy voltages like this. We should consolidate | ||
| // chip data and chips later, or design analyzer to read voltages from chips rather | ||
| // than chipdata |
There was a problem hiding this comment.
agree with both of the above TODOs.
| */ | ||
| void read_aux2_registers(cell_asic chips[NUM_CHIPS]) | ||
| { | ||
| write_config_regs(chips); |
There was a problem hiding this comment.
for all read_* commands. Why do we write to registers each time? Feels like we dont need to?
There was a problem hiding this comment.
If the chip slept, all the config registers are wiped (I think).
There was a problem hiding this comment.
Also this is from the adbms example and has worked in testing so we're keeping it for now. Agreed that we should investigate this though.
Changes
Low level drivers and some integration.
Test Cases
test bench
To Do
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #133 (issue #)