Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to decode IEEE754 32-bit floats over CAN #78

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Added support to decode IEEE754 32-bit floats over CAN #78

merged 7 commits into from
Dec 10, 2024

Conversation

harrison-e
Copy link
Contributor

Changes

  • Calypso can now read the bits of a CANPoint as an IEEE754 32-bit float.
  • To accommodate this, a new field has been added to the CAN spec. ieee754_f32 is an optional boolean field in the CANPoint spec, which indicates that the CANPoint should be decoded as an f32.

Notes

  • CANPoints that wish to use this feature must specify the ieee754_f32 field as true in the JSON.

Test Cases

Closes #75

@harrison-e harrison-e requested a review from jr1221 December 10, 2024 20:58
@harrison-e harrison-e self-assigned this Dec 10, 2024
@harrison-e harrison-e linked an issue Dec 10, 2024 that may be closed by this pull request
Support Floats #75
Closed
jr1221
jr1221 previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just fix clippy. I will create an issue to track adding little endian support, a good starter ticket.

jr1221
jr1221 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@harrison-e harrison-e merged commit 415f002 into Develop Dec 10, 2024
1 check passed
@harrison-e harrison-e deleted the feature/ieee754-f32 branch December 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jr1221 jr1221 jr1221 approved these changes

Assignees

@harrison-e harrison-e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Floats
2 participants
@harrison-e @jr1221