-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop an expired sensor #3854
base: master
Are you sure you want to change the base?
Stop an expired sensor #3854
Conversation
@Der-Schubi This should fix the problem. I will test in 10 days and update. |
Any chance we can re-enable the sensor start time in the first system status page? |
And one more question: Would the session be stopped when I enter a new sensor code? E.g. when the sensor fails and I have to set a new one. Maybe we can stop the session directly when pairing a new sensor. Automatic session start is shortly after that with the first values, right? |
The most important piece of information is when the session will stop. If the user needs to know when they started the sensor, they can easily calculate it by subtracting 10.5 days from the expected stop time. If we bring back the start time to the status page, we will only add confusion for the inexperienced. And believe me, the question will actually be asked like that? They won't say what am I missing? They will ask why is xDrip wrong? If this PR is merged, the only time the internal session will be stopped is if the user waits for their sensor to expire before switching to their new sensor. |
Where? I can't see that information anywhere in xDrip. I only see the sensor status, that says e.g. OK, 10.4 days. But that does not tell me when the session will stop. And it's resolution is only 0.1 day. Therefore I use a notebook to write down the sensor start time manually. Not very user friendly... |
We should really move this conversation to a discussion to avoid reducing the chance of this PR being approved. The item I have marked is reported by the device. It is not something xDrip calculates. It is as accurate as it can be. So, is the expiry note at the bottom of the main screen if you enable it. |
After a G7 expires, we don't stop the internal session.
When xDrip connects to the next sensor, it thinks that there is an active internal session. Therefore, it requests a full backfill causing a backfill overlap.
When we stop a G6, we also stop the internal session. After that, when we connect to a G7, xDrip starts a new session and takes into account the last readings and avoid a backfill overlap.
This PR will avoid a backfill overlap for G7 to G7 as well.
Testing
Unfortunately, I can test this in 10 days I hope. I will update then.
However, I will be able to test G6 to G7 before then to make sure nothing is negatively affected there. I will add this test's results in a day or two.