feat: 미션 상태 업데이트 배치 스케줄러 구현 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimyu0218
approved these changes
Oct 27, 2024
| @@ -30,6 +30,7 @@ dependencies { | |||
| implementation 'org.springframework.boot:spring-boot-starter-validation' | |||
| implementation 'org.springframework.cloud:spring-cloud-starter-openfeign:4.1.3' | |||
| implementation 'org.springframework.boot:spring-boot-starter-data-redis' | |||
| implementation("org.springframework.boot:spring-boot-starter-quartz") | |||
Comment on lines
88
to
91
| @Transactional | ||
| public void batchUpdate(final Long missionId) { | ||
|
|
||
| } |
Comment on lines
41
to
59
| if (now.isBefore(missionStart)) { | ||
| return PENDING; | ||
| } else if (now.isAfter(missionEnd)) { | ||
| return CREATED; | ||
| } | ||
|
|
||
| if (mission.isMissionPeriod() && currentMemberCount <= 1) { | ||
| return CANCELED; | ||
| } | ||
|
|
||
| if (mission.isMissionPeriod() && currentMemberCount > 1) { | ||
| return IN_PROGRESS; | ||
| } | ||
|
|
||
| if (now.isAfter(missionEnd) && !missionMember.getCheckCompleted()) { | ||
| return PENDING_COMPLETION; | ||
| } | ||
|
|
||
| if (now.isAfter(missionEnd) && missionMember.getCheckCompleted()) { | ||
| return COMPLETED; | ||
| } else { | ||
| return ONGOING; | ||
| } |
Comment on lines
+101
to
+111
| public void batchUpdateStatus() { | ||
| List<Mission> missions = missionRepository.findAll(); | ||
| missions.forEach(mission -> { | ||
| List<MissionMember> missionMembers = missionMemberRepository.findAllByMissionId(mission.getId()); | ||
| int memberCount = missionMembers.size(); | ||
| missionMembers | ||
| .forEach(missionMember -> { | ||
| missionMember.updateMissionStatus(mission, memberCount); | ||
| }); | ||
| }); | ||
| } |
| return new MissionsResponse( | ||
| new ProfileResponse(member.getNickname(), member.getCharacterType()), | ||
| missionVerifications.stream() | ||
| missionMembers.stream() | ||
| .map(missionVerification -> new MissionResponse( |
There was a problem hiding this comment.
여기 iterator 부분 missionMember로 해도 좋을 것 같아요
(이전에 missionVerifications여서 missionVerification으로 남아 있는 것 같아요 :)
| @Override | ||
| protected ScheduleBuilder<CronTrigger> getScheduleBuilder() { | ||
| // 00:00, 06:00, 12:00, 18:00 마다 실행 | ||
| return CronScheduleBuilder.cronSchedule("0 0 */6 * * ?") |
| add mission_status varchar(50) null; | ||
|
|
||
| alter table mission_member | ||
| add check_completed boolean default false; |
| job-store-type: jdbc | ||
| jdbc: | ||
| initialize-schema: never | ||
| schema: nexters |
There was a problem hiding this comment.
dev에서만 nexters인 이유가 있나요??
There was a problem hiding this comment.
우리 dev local DB 스키마가 nexters 라 동일 스키마 썼어요!
songyi00
force-pushed
the
feat/#80-scheduler
branch
from
6b013c2 to
4501e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #80
작업 개요
6시간 주기로 미션 상태 변경하는 배치 스케줄러 구현했습니다 ! (00:00, 06:00, 12:00, 18:00)
멀티 모듈로 변경하고 배치 애플리케이션을 따로 구성할까 생각해봤는데 현재 스펙에서는 오버엔지니어링인 것 같아
클러스터링을 제공하는 스프링 쿼츠 사용해서 스케줄러 돌리려고 합니다.
작업 사항
여기에 작성하세요
고민한 점들(필수 X)
여기에 작성하세요
스크린샷(필수 X)
여기에 작성하세요