fix: 미션 인증 유효성 검사 추가 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songyi00
approved these changes
Aug 3, 2024
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
kimyu0218
commented
Aug 4, 2024
src/main/java/com/nexters/goalpanzi/domain/mission/DayOfWeek.java
Outdated
Show resolved
Hide resolved
Comment on lines
+87
to
+108
| // TODO 프로필 생성 후 확인 필요 | ||
| // @Test | ||
| // void 특정_일자의_미션_인증_현황을_조회한다() { | ||
| // when(objectStorageClient.uploadFile(any(MultipartFile.class))).thenReturn(UPLOADED_IMAGE_URL); | ||
| // | ||
| // LoginResponse login1 = 구글_로그인(new GoogleLoginCommand(EMAIL)).as(LoginResponse.class); | ||
| // | ||
| // CreateMissionRequest missionRequest = new CreateMissionRequest(DESCRIPTION, LocalDateTime.now(), LocalDateTime.now().plusDays(1), TimeOfDay.EVERYDAY, WEEK, 1); | ||
| // MissionDetailResponse mission = 미션_생성(missionRequest, login1.accessToken()).as(MissionDetailResponse.class); | ||
| // 미션_참여(mission.invitationCode(), login1.accessToken()); | ||
| // 미션_인증(IMAGE_FILE, mission.missionId(), login1.accessToken()); | ||
| // | ||
| // LoginResponse login2 = 구글_로그인(new GoogleLoginCommand(EMAIL2)).as(LoginResponse.class); | ||
| // 미션_참여(mission.invitationCode(), login2.accessToken()); | ||
| // 미션_인증(IMAGE_FILE, mission.missionId(), login2.accessToken()); | ||
| // | ||
| // List<MissionVerificationResponse> verifications = 일자별_미션_인증_조회(mission.missionId(), LocalDate.now(), login1.accessToken()).as(List.class); | ||
| // | ||
| // assertAll( | ||
| // () -> assertThat(verifications.size()).isEqualTo(2) | ||
| // ); | ||
| // } |
There was a problem hiding this comment.
프로필_생성 부분이 없어서 에러 나서 주석 처리했어!! (닉네임, 장기말 타입 생성)
MissionVerificationResponse를 생성하는 과정에서 요청을 보낸 사람을 0번째 인덱스에 오도록 만드는데
그 때 사용하는 게 유니크한 닉네임이라서 그런 것 같아
나중에 프로필_생성 생기면 다시 주석 풀고 해볼게!!
| MissionVerificationResponse verification = 내_미션_인증_조회(1, mission.missionId(), login.accessToken()).as(MissionVerificationResponse.class); | ||
|
|
||
| assertAll( | ||
| // TODO 추후 닉네임, 장기말 타입 검증도 추가 |
There was a problem hiding this comment.
여기는 정렬하는 과정이 없어서 응답 생성하는 데 에러는 안났어!!
나중에 닉네임이랑 장기말 타입도 검증해보려구
songyi00
reviewed
Aug 4, 2024
| @@ -22,18 +23,18 @@ | |||
|
|
|||
| @RequiredArgsConstructor | |||
| @Component | |||
| public class ObjectStorageManager { | |||
| public class S3Client implements ObjectStorageClient { | |||
songyi00
reviewed
Aug 4, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import java.time.LocalDate; | |||
|
|
|||
| public record MissionVerificationCommand( | |||
| public record MissionVerificationQuery( | |||
| Long memberId, | |||
There was a problem hiding this comment.
여기 필수값 여부 스키마 주석 추가해주면 좋을 것 같아
코드보니까 date 가 nullable인 것 같아서!
There was a problem hiding this comment.
아! 이 부분 null 허용해줬어
date 안 보내면 그냥 오늘 기준으로 인증 정보 조회하도록 만들었는데 그냥 무조건 보내도록 만들까?? (딱히 이유가 있는 건 아니야!! 기본값 느낌으로..)
@Transactional(readOnly = true)
public List<MissionVerificationResponse> getVerifications(final MissionVerificationQuery query) {
LocalDate date = query.date() != null ? query.date() : LocalDate.now();
...
}There was a problem hiding this comment.
응응 기본값 오늘 기준으로 인증해줘도 괜찮을 것 같아!
쿼리 dto에 스웨거 스키마 필수값 여부만 추가해줘 ㅎㅎ
songyi00
reviewed
Aug 4, 2024
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #27
close: #26
작업 개요
작업 사항
고민한 점들(필수 X)
스크린샷(필수 X)