Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 미션 참여, 조회 API 구현 #23

Merged
merged 9 commits into from
Aug 3, 2024
Merged

Conversation

songyi00
Copy link
Member

@songyi00 songyi00 commented Aug 2, 2024

Issue Number

close: #21
close: #22
close: #24

작업 개요

여기에 작성하세요

작업 사항

  • 미션 참여 API
  • 내가 참여한 미션 조회 API

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@songyi00 songyi00 requested a review from kimyu0218 as a code owner August 2, 2024 13:21
Copy link
Collaborator

@kimyu0218 kimyu0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 너무 깔끔해 🫠 수고 많았어 👏 👏

딴말이지만 어제 도커 컴포즈 보다가 redis 연결 안됐던 이유 찾은 것 같아
api-server8080만 열어두고 6379 안 열어놔서 컨테이너랑 호스트랑 통신 못했던 거 아닐까?

Comment on lines +3 to +6
import com.nexters.goalpanzi.application.auth.dto.request.AppleLoginCommand;
import com.nexters.goalpanzi.application.auth.dto.request.GoogleLoginCommand;
import com.nexters.goalpanzi.application.auth.dto.response.LoginResponse;
import com.nexters.goalpanzi.application.auth.dto.response.TokenResponse;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Comment on lines 15 to 17
default Mission getMission(Long missionId) {
return findById(missionId)
.orElseThrow(() -> new BaseException(ErrorCode.NOT_FOUND_MISSION));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오...! 이런 것도 되는구나

@songyi00 songyi00 merged commit 4494d9c into develop Aug 3, 2024
1 check passed
@songyi00 songyi00 deleted the feat/#22-mission-members branch August 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

미션에 참여한다 참여중인 미션을 조회한다 미션(목표) 정보를 조회한다
2 participants