-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 미션 인증 생성/조회 구현 #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
충돌날까봐 mission entity랑 repository를 안 올렸더니 CI가 실패하네요 😂😂 |
songyi00
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많았어! 코멘트 확인해줘 🙆🏻♀️
+) mission entity 는 내꺼 브랜치 위에 rebase해서 써도 될 것 같아 ㅎㅎ
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/domain/mission/MissionVerification.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/domain/mission/MissionVerificationRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nexters/goalpanzi/presentation/mission/MissionVerificationController.java
Outdated
Show resolved
Hide resolved
- 불필요한 코드 삭제 - schema가 있더라고 에러 시엔 content가 보이지 않도록 수정 - 부가적인 설명이 필요한 코드에 대해서만 description 작성
- 닉네임과 인증 이미지 함께 조회 - 추후 캐릭터 이미지도 추가 필요
kimyu0218
force-pushed
the
feat/#18-mission-verification
branch
from
July 30, 2024 11:34
c6459a8
to
2c5c9f6
Compare
- 모든 미션 멤버를 조회하도록 변경 - 본인을 0번째, 인증 최신순 정렬, null을 가장 나중에
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #18
작업 개요
미션 인증 생성/조회 구현
작업 사항
조회
/api/missions/{missionId}/verifications
/api/missions/{missionId}/verifications/me/{number}
생성
/api/missions/{missionId}/verifications/me
고민한 점들(필수 X)
스크린샷(필수 X)