feat: 로그인 기능 고도화 #12
Merged
feat: 로그인 기능 고도화 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimyu0218
approved these changes
Jul 25, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @Component | ||
| public class UserKeyResolver implements HandlerMethodArgumentResolver { |
| @@ -31,7 +31,7 @@ public JwtManager( | |||
| this.refreshExpiresIn = refreshExpiresIn; | |||
| } | |||
|
|
|||
| public Jwt generateTokens(String subject) { | |||
| public com.nexters.goalpanzi.common.jwt.Jwt generateTokens(String subject) { | |||
There was a problem hiding this comment.
아..? 이름을 Jwt 말고 딴걸로 할 걸 그랬나....!!
There was a problem hiding this comment.
아 이거 import 다시 제거해서 없애놨어 ㅎㅎ
| NativeWebRequest webRequest, WebDataBinderFactory binderFactory) { | ||
| HttpServletRequest request = (HttpServletRequest) webRequest.getNativeRequest(); | ||
|
|
||
| String token = jwtParser.resolveToken(request); |
There was a problem hiding this comment.
오오 신기하다,, request만 넘겨도 알아서 토큰을 찾아서 파싱하는거야? 공부해봐야 겠다 👍👍
There was a problem hiding this comment.
토큰 찾아서 파싱하는건 직접 구현한거고 클라이언트가 요청할 때 argument resolver 타서 파라미터에 특정 조건이 있는 경우에 값 바인딩 가능하게 구현해준거야!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
로그인 기능 고도화, 리팩터링
작업 사항
고민한 점들(필수 X)
인수 테스트 주석 처리해놓은 부분은 다음 PR로 올리겠습니닷
스크린샷(필수 X)
여기에 작성하세요