refac: fix boolean value flags and update protocol url

NethermindEth · Jan 2, 2025 · 11aa2e2 · 11aa2e2
1 parent 98de90f
commit 11aa2e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/docker-compose-protocol.yml b/docker-compose-protocol.yml
@@ -13,7 +13,7 @@ services:
       - sh
       - -c
     command: >
-      'forge script ./script/shared/SetAddress.s.sol --fork-url "${FORK_URL}" --broadcast -vvv'
+      'forge script ./script/shared/SetAddress.s.sol --fork-url "${L1_ENDPOINT_HTTP}" --broadcast -vvv'
   set-signal-service-address-l1:
     image: nethsurge/protocol:surge-docs
     environment:
@@ -28,7 +28,7 @@ services:
       - sh
       - -c
     command: >
-      'forge script ./script/shared/SetAddress.s.sol --fork-url "${FORK_URL}" --broadcast -vvv'
+      'forge script ./script/shared/SetAddress.s.sol --fork-url "${L1_ENDPOINT_HTTP}" --broadcast -vvv'
     networks:
       - surge
     profiles:
@@ -42,13 +42,13 @@ services:
       ADDRESS: ${L1_BRIDGE_ADDRESS}
       NAME: ${BRIDGE_32_BYTES}
       PROXY_ADDRESS: ${L2_SHARED_ADDRESS_MANAGER}
-      FORK_URL: ${L2_ENDPOINT_HTTP}
+      FORK_URL: http://l2-nethermind-execution-client:${L2_HTTP_PORT}
       PRIVATE_KEY: ${OWNER_PRIVATE_KEY}
     entrypoint:
       - sh
       - -c
     command: >
-      'forge script ./script/shared/SetAddress.s.sol --fork-url "${FORK_URL}" --broadcast -vvv'
+      'forge script ./script/shared/SetAddress.s.sol --fork-url http://l2-nethermind-execution-client:${L2_HTTP_PORT} --broadcast -vvv'
     networks:
       - surge
     profiles:
@@ -62,13 +62,13 @@ services:
       ADDRESS: ${L2_SIGNAL_SERVICE_ADDRESS}
       NAME: ${SIGNAL_SERVICE_32_BYTES}
       PROXY_ADDRESS: ${L2_SHARED_ADDRESS_MANAGER}
-      FORK_URL: ${L2_ENDPOINT_HTTP}
+      FORK_URL: http://l2-nethermind-execution-client:${L2_HTTP_PORT}
       PRIVATE_KEY: ${OWNER_PRIVATE_KEY}
     entrypoint:
       - sh
       - -c
     command: >
-      'forge script ./script/shared/SetAddress.s.sol --fork-url "${FORK_URL}" --broadcast -vvv'
+      'forge script ./script/shared/SetAddress.s.sol --fork-url http://l2-nethermind-execution-client:${L2_HTTP_PORT} --broadcast -vvv'
     networks:
       - surge
     profiles:

diff --git a/script/start-proposer.sh b/script/start-proposer.sh
@@ -23,11 +23,11 @@ if [ "$ENABLE_PROPOSER" = "true" ]; then
     fi
 
     if [ -n "$CHECK_PROFITABILITY" ]; then
-        ARGS="${ARGS} --checkProfitability ${CHECK_PROFITABILITY}"
+        ARGS="${ARGS} --checkProfitability=${CHECK_PROFITABILITY}"
     fi
 
     if [ -n "$ALLOW_EMPTY_BLOCKS" ]; then
-        ARGS="${ARGS} --allowEmptyBlocks ${ALLOW_EMPTY_BLOCKS}"
+        ARGS="${ARGS} --allowEmptyBlocks=${ALLOW_EMPTY_BLOCKS}"
     fi
 
     if [ -n "$SURGE_PROPOSING_BLOCK_GAS" ]; then