Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blob price update fraction #8053

Open
wants to merge 10 commits into
base: eip-7840
Choose a base branch
from
Open

Conversation

tanishqjasoria
Copy link
Contributor

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@tanishqjasoria tanishqjasoria changed the title add blob price update franction add blob price update fraction Jan 14, 2025
@@ -149,6 +149,6 @@ public void Test_StoreBeaconRoot_AccessListNotNull()

transaction.Hash = transaction.CalculateHash();
_transactionProcessor.Received().Execute(Arg.Is<Transaction>(t =>
t.Hash == transaction.Hash), header, NullTxTracer.Instance);
t.Hash == transaction.Hash), new BlockExecutionContext(header, 0), NullTxTracer.Instance);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is assuming that system transaction will not have blobs, so 0 blobBaseFee will not be a issues.

else
{
spec.BlobBaseFeeUpdateFraction = blobCount.BaseFeeUpdateFraction;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a temp things, untill this gets merged

@tanishqjasoria tanishqjasoria marked this pull request as ready for review January 15, 2025 09:00
@@ -12,12 +13,12 @@ public readonly struct BlockExecutionContext
public BlockHeader Header { get; }
public UInt256? BlobBaseFee { get; }

public BlockExecutionContext(BlockHeader blockHeader)
public BlockExecutionContext(BlockHeader blockHeader, IReleaseSpec spec)
Copy link
Member

@LukaszRozmej LukaszRozmej Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor idea:
Maybe we should save the whole spec and reuse it later, while removing SpecProvider dependency and manually getting spec in lot of places in VM or TransactionProcessor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a good idea, i will explore this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants