Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ticker and timer for subscribeTransactionStatus #2376

Merged

Conversation

IronGauntlets
Copy link
Contributor

If the transaction is not found within 10 seconds of creating the subscription, then return a transaction not found error.

@IronGauntlets IronGauntlets enabled auto-merge (squash) January 14, 2025 19:27
If the transaction is not found within 5 minutes of creating the
subscription, then return a transaction not found error.
@IronGauntlets IronGauntlets force-pushed the IronGauntlets/ws-tx-status-timeour-for-unkown-txHash branch from 82626ac to 9c60ee7 Compare January 14, 2025 19:28
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (27b6968) to head (9c60ee7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/subscriptions.go 63.63% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   74.62%   74.57%   -0.06%     
==========================================
  Files         110      110              
  Lines       12024    12043      +19     
==========================================
+ Hits         8973     8981       +8     
- Misses       2354     2362       +8     
- Partials      697      700       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IronGauntlets IronGauntlets merged commit 2a572d9 into main Jan 15, 2025
13 checks passed
@IronGauntlets IronGauntlets deleted the IronGauntlets/ws-tx-status-timeour-for-unkown-txHash branch January 15, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants