Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource bound nil pointer error during p2p sync #1726

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

IronGauntlets
Copy link
Contributor

No description provided.

Paymaster and AccountDeploymentData have different types, which cannot
be easily converted between core and p2p types; therefore, they have
been left as nil.
@IronGauntlets IronGauntlets force-pushed the IronGauntlets/p2p/fix-v3-resoucse-bound-error branch from a3fd43e to 4333394 Compare February 27, 2024 00:01
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (6e8c601) to head (4333394).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files          90       90           
  Lines        9631     9631           
=======================================
  Hits         7273     7273           
  Misses       1828     1828           
  Partials      530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IronGauntlets IronGauntlets merged commit 61adba3 into main Feb 27, 2024
10 checks passed
@IronGauntlets IronGauntlets deleted the IronGauntlets/p2p/fix-v3-resoucse-bound-error branch February 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants