Make all (?) fields & rings attribute storing #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I don't have an immediate application, all other field and ring types in Nemo (and most in Oscar) are attribute storing (be it via an explicit @attributes, or because they are singleton types). So it seems sensible to also enable it for these types proactively. Otherwise we end up writing "generic" code using attributes that doesn't work on all kinds of rings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
- Coverage 84.53% 84.49% -0.04%
==========================================
Files 94 94
Lines 37084 37084
==========================================
- Hits 31348 31335 -13
- Misses 5736 5749 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I don't have an immediate application, all other field and ring
types in Nemo (and most in Oscar) are attribute storing (be it via an
explicit @attributes, or because they are singleton types). So it seems
sensible to also enable it for these types proactively. Otherwise
we end up writing "generic" code using attributes that doesn't work on
all kinds of rings.
(Old branch I had still sitting on my disk)