Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more flint nullspaces + linear solving clean-up #1681

Merged
merged 14 commits into from
Feb 25, 2024

Conversation

joschmitt
Copy link
Collaborator

No description provided.

src/flint/fmpz_mod_mat.jl Outdated Show resolved Hide resolved
@thofma thofma closed this Feb 22, 2024
@thofma thofma reopened this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 98.13953% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.34%. Comparing base (4111c9f) to head (05dd769).
Report is 2 commits behind head on master.

Files Patch % Lines
src/flint/fmpz_mat.jl 94.11% 2 Missing ⚠️
src/matrix.jl 97.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   84.37%   84.34%   -0.04%     
==========================================
  Files          94       94              
  Lines       37265    37065     -200     
==========================================
- Hits        31444    31262     -182     
+ Misses       5821     5803      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joschmitt joschmitt changed the title Use more flint nullspaces Use more flint nullspaces + linear solving clean-up Feb 23, 2024
@lgoettgens lgoettgens requested a review from thofma February 23, 2024 14:21
@thofma
Copy link
Member

thofma commented Feb 25, 2024

Nice, thanks!

@thofma thofma merged commit 4a1abac into Nemocas:master Feb 25, 2024
14 of 15 checks passed
@joschmitt joschmitt deleted the js/nullspace branch February 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants