Add is_prime(char) check to GF(char, k)
#1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
=======================================
Coverage 84.14% 84.15%
=======================================
Files 94 94
Lines 36854 36857 +3
=======================================
+ Hits 31011 31017 +6
+ Misses 5843 5840 -3 ☔ View full report in Codecov by Sentry. |
thofma
requested changes
Dec 15, 2023
A DomainError is consistent with the other constructors. Furthermore, Nemo uses DomainErrors a lot, so I would rather change that in a future PR (maybe once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1493 by adding an analogous check as for the modulus of a polynomial in
ZZ/nZZin that constructor.cc @mjrodgers