Make digits
for negative ZZRingElem
consistent
#1590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
digits
function behaves inconsistent with julia integer types for negative numbers:From the tests, I would assume that the result for
ZZRingElem
andBigInt
should coincide; the tests are of course only for positive numbers though.The issue is that
Nemo.divrem
is not the same asBase.divrem
as I learnt from this comment here:Nemo.jl/src/flint/fmpz.jl
Line 629 in 659462d