FinField: use concrete types for sub-/overfield morphisms to improve …

…inferrability (#1961)
Nemocas · Dec 5, 2024 · e4e5751 · e4e5751
1 parent 3490994
commit e4e5751
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/src/embedding/embedding.jl b/src/embedding/embedding.jl
@@ -10,18 +10,18 @@
 #
 ################################################################################
 
-function overfields(k::FinField)
+function overfields(k::T) where T <: FinField
   if !isdefined(k, :overfields)
-    k.overfields = Dict{Int, Vector{FinFieldMorphism}}()
+    k.overfields = Dict{Int, Vector{FinFieldMorphism{T,T}}}()
   end
-  return k.overfields
+  return k.overfields::Dict{Int, Vector{FinFieldMorphism{T,T}}}
 end
 
-function subfields(k::FinField)
+function subfields(k::T) where T <: FinField
   if !isdefined(k, :subfields)
-    k.subfields = Dict{Int, Vector{FinFieldMorphism}}()
+    k.subfields = Dict{Int, Vector{FinFieldMorphism{T,T}}}()
   end
-  return k.subfields
+  return k.subfields::Dict{Int, Vector{FinFieldMorphism{T,T}}}
 end
 
 

diff --git a/src/flint/FlintTypes.jl b/src/flint/FlintTypes.jl
@@ -1845,8 +1845,8 @@ See [`FqPolyRepField`](@ref) for $p$ being a [`ZZRingElem`](@ref). See [`fqPolyR
   var :: Ptr{Nothing}
   # end of flint struct
 
-  overfields :: Dict{Int, Vector{FinFieldMorphism}}
-  subfields :: Dict{Int, Vector{FinFieldMorphism}}
+  overfields :: Dict{Int, Vector{FinFieldMorphism{fqPolyRepField, fqPolyRepField}}}
+  subfields :: Dict{Int, Vector{FinFieldMorphism{fqPolyRepField, fqPolyRepField}}}
 
   function fqPolyRepField(c::UInt, deg::Int, s::Symbol, cached::Bool = true; check::Bool = true)
     check && !is_prime(c) &&
@@ -1973,8 +1973,8 @@ A finite field. The constructor automatically determines a fast implementation.
 
   var::String
 
-  overfields::Dict{Int, Vector{FinFieldMorphism}}
-  subfields::Dict{Int, Vector{FinFieldMorphism}}
+  overfields::Dict{Int, Vector{FinFieldMorphism{FqField, FqField}}}
+  subfields::Dict{Int, Vector{FinFieldMorphism{FqField, FqField}}}
 
   isstandard::Bool
   # isstandard means, that defining_polynomial(F) === modulus(F)
@@ -2148,8 +2148,8 @@ See [`fqPolyRepField`](@ref) for $p$ being an [`Int`](@ref). See [`FqPolyRepFiel
   var::Ptr{Nothing}
   # end of flint struct
 
-  overfields :: Dict{Int, Vector{FinFieldMorphism}}
-  subfields :: Dict{Int, Vector{FinFieldMorphism}}
+  overfields :: Dict{Int, Vector{FinFieldMorphism{FqPolyRepField, FqPolyRepField}}}
+  subfields :: Dict{Int, Vector{FinFieldMorphism{FqPolyRepField, FqPolyRepField}}}
 
   function FqPolyRepField(char::ZZRingElem, deg::Int, s::Symbol, cached::Bool = true; check::Bool = true)
     check && !is_probable_prime(char) &&