Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to parse FeatureRegistry so no overlap in kwargs #255

Merged
merged 4 commits into from
Jan 17, 2025
Merged

need to parse FeatureRegistry so no overlap in kwargs #255

merged 4 commits into from
Jan 17, 2025

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from bnb32 January 15, 2025 15:29
bnb32
bnb32 reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you might run into issues with this kwarg, and it shows that the DataHandlerFactorywas just an example of being fancy for the sake of being fancy. Removed this and resolved the kwarg pass through in #256

grantbuster and others added 4 commits January 16, 2025 10:28
@grantbuster @bnb32
need to parse FeatureRegistry so no overlap in kwargs
fd697c3
@bnb32
Decided the data handler factory was not simplifying anything and com…
383e990 
…plicating the FeatureRegistry input. Removed this and redefined the 3 extended handlers that were previously using the factory through inheritance.
@bnb32
renamed data_handers.factory to data_handlers.base, after removal of …
1d99587 
…explicit factory class. Clarified which class were inherited and composed in doc strings.
@bnb32
FeatureRegistry update -> defined with argument.
03058b6
@grantbuster grantbuster merged commit 212a77f into main Jan 17, 2025
12 checks passed
@grantbuster grantbuster deleted the gb/reg_inp branch January 17, 2025 16:33
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
@grantbuster
Merge pull request #255 from NREL/gb/reg_inp
e03d062 
need to parse FeatureRegistry so no overlap in kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb32 bnb32 bnb32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantbuster @bnb32