Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCS::check
waszip
ping the commitments, proofs and claimed values. The issue is thatzip
is happy to combine two vectors of unequal length, in which case it drops off the excess elements from the longer vector. This could be dangerous, sincecheck
fails iff any of the individual proof checks fails, but those checks could be missed.We considered using
zip_eq
, which panics if the iterators have different length. In the end, we opted for checking the lengths by hand so that we could control the error and return it. Unfortunately, this results in less-than-ideal syntax (but still acceptable), since one can't count an iterator and then iterate over it.@autquis this is likely also relevant to the Brakedown and Ligero PRs. Let's keep it in mind, even if it's not an urgent fix :)