Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Hyrax checks #66

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Reorder Hyrax checks #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions poly-commit/src/hyrax/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,6 @@ where
});
}

// Computing t_prime with a multi-exponentiation
let l_bigint = cfg_iter!(l)
.map(|chi| chi.into_bigint())
.collect::<Vec<_>>();
let t_prime: G = <G::Group as VariableBaseMSM>::msm_bigint(&row_coms, &l_bigint).into();

// Absorbing public parameters
sponge.absorb(
&Blake2s256::digest(serialize_to_vec!(*vk).map_err(|_| Error::TranscriptError)?)
Expand All @@ -499,15 +493,22 @@ where
// it from the transcript.
let c: G::ScalarField = sponge.squeeze_field_elements(1)[0];

// First check
let com_z_zd = (Self::pedersen_commit(&vk.com_key, z) + vk.h * z_d).into();
if com_z_zd != (t_prime.mul(c) + com_d).into() {
// Second check from the paper (figure 6, equation (14))
// Moved here for potential early return
let com_dp = (vk.com_key[0] * inner_product(&r, z) + vk.h * z_b).into();
if com_dp != (com_eval.mul(c) + com_b).into() {
return Ok(false);
}

// Second check
let com_dp = (vk.com_key[0] * inner_product(&r, z) + vk.h * z_b).into();
if com_dp != (com_eval.mul(c) + com_b).into() {
// Computing t_prime with a multi-exponentiation
let l_bigint = cfg_iter!(l)
.map(|chi| chi.into_bigint())
.collect::<Vec<_>>();
let t_prime: G = <G::Group as VariableBaseMSM>::msm_bigint(&row_coms, &l_bigint).into();

// First check from the paper (figure 6, equation (13))
let com_z_zd = (Self::pedersen_commit(&vk.com_key, z) + vk.h * z_d).into();
if com_z_zd != (t_prime.mul(c) + com_d).into() {
return Ok(false);
}
}
Expand Down
Loading