Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/week04 xml #5

Open
wants to merge 25 commits into
base: develop-xml
Choose a base branch
from
Open

Feat/week04 xml #5

wants to merge 25 commits into from

Conversation

t1nm1ksun
Copy link
Member

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

4์ฃผ์ฐจ xml ํ•„์ˆ˜๊ณผ์ œ

๐ŸŒฑ PR ํฌ์ธํŠธ

API๋ฅผ ํ†ตํ•ด ํšŒ์›๊ฐ€์ž…, ๋กœ๊ทธ์ธ , ๋น„๋ฐ€๋ฒˆํ˜ธ ๋ณ€๊ฒฝ ๊ตฌํ˜„
๋กœ๊ทธ์ธ์ด ๋˜๊ณ ๋‚˜๋ฉด ์ด์ „ ์Šคํƒ์„ ์ง€์›Œ ๋’ค๋กœ๊ฐ€๊ธฐ ๋ฒ„ํŠผ ํด๋ฆญ์‹œ ๋กœ๊ทธ์ธ์œผ๋กœ ๋Œ์•„๊ฐ€์ง€ ์•Š๋„๋ก ํ•จ

week04_xml.mp4

@t1nm1ksun t1nm1ksun requested a review from a team May 3, 2024 09:51
Copy link
Member

@0se0 0se0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~


binding.rvFriends.run {
adapter = concatAdapter
layoutManager = LinearLayoutManager(requireContext())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml์—์„œ LayoutManager ์„ค์ •ํ•ด์ฃผ์…”์„œ ์—ฌ๊ธฐ์„œ ๋”ฐ๋กœ ๋˜ ์„ค์ • ์•ˆ ํ•˜์…”๋„ ๋  ๊ฒƒ ๊ฐ™์•„์š”!

Comment on lines +44 to +54
binding.textNickname.text = getString(R.string.nickname, nickname)
binding.textPhone.text = phone
binding.textId.text = id
binding.changePw.setOnClickListener {
Log.d("MyPapgeFragment", "go ChangePasswordActivity")
val intentChangePassword = Intent(activity, ChangePasswordActivity::class.java).apply {
putExtra("memberId", memberID)
}
startActivity(intentChangePassword)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•จ์ˆ˜ํ™” ํ•ด์ฃผ์‹œ๋ฉด ์ฝ๊ธฐ ๋” ์ข‹์„ ๊ฑฐ ๊ฐ™์•„์š”!

Comment on lines +11 to +12
binding.run {
ivProfile.setImageResource(friendData.profileImage)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค binding.run ์‚ฌ์šฉํ•˜์…จ๋„ค์š”

twogarlic

This comment was marked as duplicate.

if (response.isSuccessful) {
userId = response.body()!!.data.authenticationId
userNickname = response.body()!!.data.nickname
userPhone = response.body()!!.data.phone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response.body()์— ์—ฌ๋Ÿฌ ๋ฒˆ ์ ‘๊ทผํ•˜๋Š” ๊ฑธ ์กธ์—ฌ์„œ ์ฝ”๋“œ๋ฅผ ๊ฐ„๋‹จํ•˜๊ฒŒ ํ•  ์ˆ˜ ์—†์„๊นŒ์š”

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! ์•ˆ์“ฐ๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”

@t1nm1ksun t1nm1ksun requested review from kez-lab and Sangwook123 May 5, 2024 12:28
Copy link

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค !

}

private fun initViews() {
val memberId = intent.getIntExtra("memberId", 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initViews๋ผ๋Š” ํ•จ์ˆ˜๋ช…์— ํ•ด๋‹น๋˜๋Š” ๊ธฐ๋Šฅ๋“ค์ธ๊ฐ€์š”?

_binding = null
}

private val myProfile = listOf(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAC Viewmodel์‚ฌ์šฉํ•ด์„œ ๋ฐ์ดํ„ฐ ๊ด€๋ฆฌํ•ด๋ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค

_binding = FragmentMypageBinding.inflate(inflater, container, false)
return binding.root


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ctrl + Alt + L ํ™œ์šฉํ•ด ๋ณด์„ธ์šฉ


}

//class SignUpActivity : AppCompatActivity() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•„์š”์—†๋Š” ์ฝ”๋“œ๋Š” ์ฃผ์„์ฒ˜๋ฆฌ ํ•˜๊ธฐ๋ณด๋‹จ ๊ทธ๋ƒฅ ์ง€์›Œ์ฃผ์…”๋„ ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค

if (response.isSuccessful) {
userId = response.body()!!.data.authenticationId
userNickname = response.body()!!.data.nickname
userPhone = response.body()!!.data.phone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! ์•ˆ์“ฐ๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”


fun setFriendList(friendList: List<Friend>) {
this.friendList = friendList.toList()
notifyDataSetChanged()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notifyDataSetChanged์˜ ๋‹จ์ ์ด ๋ญ˜๊นŒ์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants