Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of verbose option in time_interp_external2 calls from data_override #1516

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented May 9, 2024

Description
In data_override_mod, rather than calling time_interp_external2 subroutines with a hardcoded verbose=.false. parameter, verbose is now controlled by the debug_data_override namelist variable from data_override_nml. Excess spaces before line-continuation ampersands were removed as well.

Fixes #1398

How Has This Been Tested?
Builds on the AMD box with Intel compiler version 2024.1.0.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

In `data_override_mod`, rather than hardcoding `verbose=.false.` in calls to
`time_interp_external2`, the `verbose` parameter is now controlled by the
`debug_data_override` namelist variable. Excess spaces before line-continuation
ampersands were removed as well.
rem1776
rem1776 previously approved these changes May 30, 2024
@rem1776
Copy link
Contributor

rem1776 commented May 30, 2024

@J-Lentz Just realized this is failing the linter, looks like there's a line length > 120 in data_override.inc

Break excessively long lines and fix several instances of inconsistent
indentation.
@J-Lentz
Copy link
Contributor Author

J-Lentz commented May 31, 2024

@J-Lentz Just realized this is failing the linter, looks like there's a line length > 120 in data_override.inc

Fixed in 2c32f59.

@rem1776 rem1776 merged commit 0c77856 into NOAA-GFDL:main Jun 21, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data_override hardcodes verbose flags to .false.
2 participants