Modern_diag_manager:: 0 days freq, mix_snapshot_average_fields deprecation #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
changed the title
…averaged and non averaged
rem1776
previously approved these changes
May 9, 2024
rem1776
reviewed
May 9, 2024
| @@ -94,7 +94,7 @@ module fms_diag_file_object_mod | |||
| integer :: number_of_axis !< Number of axis in the file | |||
| integer, dimension(:), allocatable :: buffer_ids !< array of buffer ids associated with the file | |||
| integer :: number_of_buffers !< Number of buffers that have been added to the file | |||
| logical :: time_ops !< .True. if file contains variables that are time_min, time_max, time_average or time_sum | |||
| logical, allocatable :: time_ops !< .True. if file contains variables that are time_min, time_max, time_average or time_sum | |||
There was a problem hiding this comment.
this is getting flagged by the linter since its over the character limit
rem1776
approved these changes
May 9, 2024
| @@ -850,7 +851,7 @@ subroutine fms_diag_do_io(this, end_time) | |||
| ! Go away if there is no data to write | |||
| if (.not. diag_buff%is_there_data_to_write()) cycle | |||
|
|
|||
| if ( diag_buff%is_time_to_finish_reduction(end_time)) then | |||
| if ( diag_buff%is_time_to_finish_reduction(end_time) .and. .not. do_not_write) then | |||
thomas-robinson
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0 dayscapability into the new diag manager-1 daysor0 daysFixes #1498
Fixes #1499
How Has This Been Tested?
CI, including new tests
Checklist:
make distcheckpasses