Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variables named value to other variable names #1377

Merged
merged 35 commits into from
Nov 13, 2023

Conversation

mcallic2
Copy link
Contributor

@mcallic2 mcallic2 commented Sep 27, 2023

Description
Fortran added the value type declaration in 2003. This PR suggests changes to these variable names, and does not include any directories/modules that are either no longer used and/or deprecated (i.e. axis_utils, mpp_io, fms_io, etc).

Fixes ##1328

How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@mcallic2 mcallic2 requested a review from rem1776 as a code owner September 27, 2023 16:32
@mcallic2 mcallic2 changed the title Value Change variables named value to other variable names Sep 27, 2023
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In axis_utils2.inc, you are keeping the 'value' name, where as the others are shortened to _x_val where the x is shorthand for the type. I think it would be good to stick to a single convention throughout.

…_value` to `rval` in routine nearest_index
@mcallic2
Copy link
Contributor Author

mcallic2 commented Sep 28, 2023

@bensonr I love me some cohesiveness, these variable names are changed in d7e68fd

bensonr
bensonr previously approved these changes Oct 4, 2023
rem1776
rem1776 previously approved these changes Nov 9, 2023
@rem1776 rem1776 dismissed stale reviews from bensonr and themself via 9658a9a November 9, 2023 14:24
rem1776
rem1776 previously approved these changes Nov 9, 2023
mosaic2/mosaic2.F90 Outdated Show resolved Hide resolved
bensonr
bensonr previously approved these changes Nov 9, 2023
@rem1776
Copy link
Contributor

rem1776 commented Nov 9, 2023

@mcallic2 looks like an old value snuck in from the main merge:

mosaic2.F90(399): error #6303: The assignment operation or the binary expression operation is invalid for the data types of the two operands.   [STRING]
         value(parse_string) = string(first:length)
-------------------------------^

@mcallic2
Copy link
Contributor Author

mcallic2 commented Nov 9, 2023

@mcallic2 looks like an old value snuck in from the main merge:

mosaic2.F90(399): error #6303: The assignment operation or the binary expression operation is invalid for the data types of the two operands.   [STRING]
         value(parse_string) = string(first:length)
-------------------------------^

should be fixed now

@rem1776 rem1776 merged commit 302e3cb into NOAA-GFDL:main Nov 13, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants