-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change variables named value
to other variable names
#1377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In axis_utils2.inc, you are keeping the 'value' name, where as the others are shortened to _x_val where the x is shorthand for the type. I think it would be good to stick to a single convention throughout.
…_value` to `rval` in routine nearest_index
This reverts commit a29c992.
@mcallic2 looks like an old
|
should be fixed now |
Description
Fortran added the
value
type declaration in 2003. This PR suggests changes to these variable names, and does not include any directories/modules that are either no longer used and/or deprecated (i.e. axis_utils, mpp_io, fms_io, etc).Fixes ##1328
How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5
Checklist:
make distcheck
passes