-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radiation analysis fix #5
Open
aradhakrishnanGFDL
wants to merge
25
commits into
NOAA-GFDL:main
Choose a base branch
from
aradhakrishnanGFDL:radiation_analysis_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Radiation analysis fix #5
aradhakrishnanGFDL
wants to merge
25
commits into
NOAA-GFDL:main
from
aradhakrishnanGFDL:radiation_analysis_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile script had a few errors that kept it from generating the Makefiles. Although, I think there are still issues that may keep the Makefiles from working correctly.
Following the SM2 public release, this adds pregenerated Makefiles that remove the need for external users to use mkmf to generate Makefiles.
MOM6, current, does not support openMP. The Makefile now does not pass the OPENMP macro to the MOM6 submake.
The -fp-model source option is needed to allow the model to run. Also corrected the NO_OVERRIDE_LIMIT macro option
The data files linked to in the documentation use 216 MPI processes for the run. Updated the run script to match.
Includes partial build and run instructions. Include updated links to data files.
Add links to the components added as submodule in the README.md file.
Correct spelling mistakes in README.md
Removed to no longer required build directory.
Added the git commit has for the components currently stored in the GFDL intenral git repositories. This is to help if/when there are support or community supplied bug fixes. Also corrected the clone --recursive option in the cloning instructions.
Updates to allow build/run with sample data set
hyperlinks to obtaining input data was not right, fixed now
@aradhakrishnanGFDL does this still need to be merged? It looks like there are conflicts now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of notebook cells were missing. I just added them back.