[production/RRFS.v1] MYNN PBL update for RRFS.v1 #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DusanJovic-NOAA
changed the title
|
Please fill out the PR description template. Dependencies, issues, testing status etc. |
|
@haiqinli Please merge in the latest production/RRFS.v1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
-- Update the MYNN PBL for the RRFS.v1 code freeze.
What bug does it fix, or what feature does it add?
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue) (#320)
Is a change of answers expected from this PR?
-- Yes.
Issue(s) addressed
Testing
How were these changes tested?
--Yes
What compilers / HPCs was it tested with?
-- Intel/Jet.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
-- Yes
Have the ufs-weather-model regression test been run? On what platform?
-- Not yet. It is being test with retro runs on Jet.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?