Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface runoff output change in the RUC LSM driver #777

Closed
wants to merge 1 commit into from

Conversation

tanyasmirnova
Copy link
Contributor

Description

The output of surface runoff is changed from instantaneous to accumulated surface runoff in the RUC LSM driver.

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

Issue(s) addressed

This change addresses the issue ufs-community/ccpp-physics#164

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

PR#164

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@DusanJovic-NOAA DusanJovic-NOAA changed the title Update .gitmodules and submodule pointers for ccpp/physics code Surface runoff output change in the RUC LSM driver Feb 9, 2024
@grantfirl
Copy link
Collaborator

@jkbk2004 This PR can be closed because the changes are contained in #785. Although that is going to the RRFS release branch, these changes will make their way to develop after the release.

@jkbk2004
Copy link
Collaborator

followed on #785

@jkbk2004 jkbk2004 closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants