Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to write 3d soilt, soilw and soill variables to a history file #744

Merged
merged 10 commits into from
Feb 15, 2024

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

This PR adds three 3D soil variables (soilt, soilw and soill) to a history file if corresponding entries are specified in diag_table file. The new 3d versions of these variables is identical to a set of 2d variables currently available (soilt1, soilt2, etc)

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel and GNU / Hera
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes.
On what platform? Hera

  • Will the code updates change regression test baseline? Yes, control_CubedSphereGrid_parallel regression test is modified to output 3d version of soilt, soilw and soill variables.

Dependencies

N/A

@zach1221 zach1221 requested a review from jkbk2004 February 13, 2024 18:13
@FernandoAndrade-NOAA
Copy link

@jkbk2004 could you please approve this when available, thanks! Testing on #2062 has completed successfully.

@jkbk2004 jkbk2004 merged commit 0fe9ba3 into NOAA-EMC:develop Feb 15, 2024
2 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the zsoil branch February 15, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vertical dimension to certain surface fields
5 participants