Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WW3 cap for 2-way ocean-wave coupling #1348

Open
wants to merge 2 commits into
base: dev/ufs-weather-model
Choose a base branch
from

Conversation

binli2337
Copy link

Pull Request Summary

The file wav_import_export.F90 located at model/src will be updated to convert a missing value to zero for the HAFS application.

Description

The HAFS application in the ufs-weather-model will be updated to include 2-way ocean-wave coupling capability. The related CMEPS component will be updated to interpolate ocean-current fields from MOM6 grid to WW3 grid. Since regional MOM6 domain and regional WW3 domain do not completely overlap, a missing value is assigned to the interpolated fields in the non-overlapped regions. In the CMEPS component, the missing value is 9.99e20.
To prevent a model crash, a short-term solution is to convert the missing value to zero in the file model/src/wav_import_export.F90. In the future, the ocean-current fields in the non-overlapped regions can be provided from a global MOM6 output.

Issue(s) addressed

-fixes #1346

Commit Message

Converting a missing value to zero for the imported ocean-current fields.

Check list

Testing

  • How were these changes tested? These changes have been tested using the ufs-weather-model regression test system. Five HAFS tests with the regional WW3 component will change results since a modified mod_def.ww3 file is used to include additional output fields.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@@ -357,6 +359,11 @@ subroutine import_fields( gcomp, time0, timen, rc )
if (state_fldchk(importState, 'So_u')) then
call SetGlobalInput(importState, 'So_u', vm, global_data, rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
do isea = 1,nsea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be isolated so as to not to affect other users of the WW3 mesh cap.

@JessicaMeixner-NOAA
Copy link
Collaborator

@binli2337 is there a corresponding ufs-weather-model PR or did I miss it?

@JessicaMeixner-NOAA
Copy link
Collaborator

@binli2337 We need a ufs-weather-model PR to correspond with this. I did a quick test and my log is here:
/work2/noaa/marine/jmeixner/hercules/PR_WW3/ufs-ww3pr1348/ufs-weather-model/tests/logs/RegressionTests_hercules.log

I did not get the same results as you - all tests were the same, which honestly I was a little surprised about. I agree with @DeniseWorthen though- it would be best if this was isolated with a flag to turn on/off this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants