Plot postprocessed ice concentration increment #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Looks good to me. I'll wait for @apchoiCMD 's review before merging.
|
Please wait on merging: this also requires global-workflow PR; I'm running some final sanity check tests and will push it soon! |
14 tasks
|
I've opened NOAA-EMC/global-workflow#3235. The dependencies are:
I am not sure what this means in terms of what should be merged in what order, happy for someone else to decide 😆 ! |
shlyaeva
dismissed stale reviews from guillaumevernieres and apchoiCMD
via
aa7dde4
|
I've merged jcb-gdas changes and updated hash here; ready for re-review and merge, I'll then update the global-workflow PR's GDASapp hash. |
guillaumevernieres
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add plots to offline vrfy to output postprocessed (aka what get added to CICE restart) sea ice increment.
Companion PRs
NOAA-EMC/jcb-gdas#64
NOAA-EMC/global-workflow#3235
Issues
Resolves #1402
Automated CI tests to run in Global Workflow
Since it's offline vrfy, no tests would cover it currently.