[DEMO NOT FOR MERGE] Adding support for NetCDF datasets in CMR #714
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ); | ||
|
|
||
| const commonTimeseriesParams = { | ||
| isPeriodic: data['dashboard:is_periodic'], | ||
| timeDensity: data['dashboard:time_density'] | ||
| isPeriodic: data['dashboard:is_periodic'] || true, |
There was a problem hiding this comment.
Is this a temporary measure? Or we won't be able to get is_periodic or time_density data from zarr cmr?
There was a problem hiding this comment.
we won't be able to get is_periodic or time_density from NASA's CMR STAC so we need some fallback, but I think a better way may be to make this parameter configurable in the dataset configuration page, do you think that would be straight forward to do?
| ? data.summaries.datetime | ||
| : data.extent.temporal.interval[0]; | ||
| const lastDatetime = domain[domain.length - 1] | ||
| if (lastDatetime == null) { | ||
| domain[domain.length - 1] = new Date().toISOString() |
There was a problem hiding this comment.
I don't think I understand what is going on with temporal interval. Can you explain why this step is necessary for netCDF data?
There was a problem hiding this comment.
For each of these colletions, the CMR STAC record's second temporal extent is null (see GPM_3IMERGDF.v07 and TRMM_3B42_Daily.v7,
"temporal":{"interval":[["1998-01-01T00:00:00.000Z",null]]}
|
@hanbyul-here good question. NetCDF and zarr can be treated in the same way, the difference is that NetCDF is a single file and Zarr URL points to the entrypoint of a zarr store which is many small files representing metadata or chunks of data values or coordinate data. I could definitely imagine we may need better constructs for handling cases of Zarr vs NetCDF but I'm not sure it's necessary yet. |
|
Closing in favor of #782 |
No description provided.