refactor(card): deprecate linkProperties on the Card Component #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated type definitions to ensure `to` and `onClick` cannot be present simultaneously - Added JSDoc comments for better documentation and clarity - Included a warning for deprecated props `linkTo` and `linkProperties` - Handled non-interactive card case where neither `to` nor `onClick` is provided
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1344
Description of Changes
toandonClickcannot be present simultaneouslylinkToandlinkPropertiestonoronClickis providedNotes & Questions About Changes
The main focus of this change was to use the new Link component from the provider but to keep backwards compatibility with existing implementations.
Validation / Testing
I suggest visiting E&A and Stories page and confirm the previous behaviour hasn't changed. Another thing is to check if a lint warning is shown when trying to using
toandonClickproperties at the same time on a Card component.This is ready for a review.