Code review 2 - DON'T MERGE #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelsh
reviewed
Mar 30, 2017
tools/srcServer.js
Outdated
| @@ -32,6 +32,9 @@ const Pet = require('../models/pet'); | |||
| const petRoutes = require('../routes/petRoutes'); | |||
| //End | |||
|
|
|||
| // Best not to expose all your React components here, only the files you want | |||
| // to serve up without transpilation. You can move the index.html and style.css | |||
| // to a folder (maybe 'public'), and express.static only those two files. - Harold | |||
| app.use(express.static('src')); | |||
|
|
|||
| app.use(require('webpack-dev-middleware')(compiler, { | |||
There was a problem hiding this comment.
I'd love to hear more about the filter on your DisplayPets constructor.
albi0025
reviewed
Mar 31, 2017
| @@ -1,10 +1,11 @@ | |||
| // seems to work using import. good to resolve any remaining issues. | |||
| // Please only include the needed helper code now - not sure what is still being used | |||
There was a problem hiding this comment.
Do you mean delete the Runner files that I used to test before we moved the functions to srcServer?
There was a problem hiding this comment.
You can keep the runner files if they help you test - but maybe rename them to testScrapeRunner.js and testSyncRunner.js.
albi0025
reviewed
Mar 31, 2017
| @@ -1,3 +1,4 @@ | |||
| // This isn't safe - let's move this to an environment variable | |||
There was a problem hiding this comment.
Not sure what you mean? Store the secret in a variable?
There was a problem hiding this comment.
Yup - instead of putting your secret on a public github file (configAuth.js), you could put it in an environment variable the way we manage PORT and MONGODB_URI in the srcServer.js file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.