add iam authentication support #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#372 looks to cover this, no? |
This PR allows setting the role to assume in providers config as also the aws provider do. For our usecase this would be the better approach. |
@Mongey With the above in mind, what would be needed to include these changes as well? |
sappusaketh
reviewed
Feb 29, 2024
| @@ -46,9 +69,12 @@ func (c *Config) newKafkaConfig() (*sarama.Config, error) { | |||
| case "scram-sha256": | |||
| kafkaConfig.Net.SASL.SCRAMClientGeneratorFunc = func() sarama.SCRAMClient { return &XDGSCRAMClient{HashGeneratorFcn: SHA256} } | |||
| kafkaConfig.Net.SASL.Mechanism = sarama.SASLMechanism(sarama.SASLTypeSCRAMSHA256) | |||
| case "iam": | |||
|
@sergeyyegournov can you please update your PR with latest changes on master we do need this feature. If you don't have time please lmk I will open one from my end |
|
superseded by #391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add aws iam authentication support via oauth sasl mechanism