Skip to content

Commit

Permalink
sleep before running acc tests (#440)
Browse files Browse the repository at this point in the history
* sleep before running acc tests
* Allow more time to produce messages
  • Loading branch information
Mongey authored Aug 9, 2024
1 parent db9b02b commit 52876a8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ jobs:
restore-keys: |
${{ runner.os }}-go-
- name: Bring up kafka + zk
run: docker compose up -d
run: docker compose up -d --wait
- name: "Run tests"
run: make testacc
run: sleep 10 && make testacc
1 change: 0 additions & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ testacc:
KAFKA_CLIENT_KEY_PASSPHRASE=test-pass \
KAFKA_SKIP_VERIFY=false \
KAFKA_ENABLE_TLS=true \
TF_LOG=DEBUG \
TF_ACC=1 go test ./kafka -v $(TESTARGS) -timeout 9m -count=1

.PHONY: build test testacc
1 change: 1 addition & 0 deletions kafka/resource_kafka_topic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ func testResourceTopic_produceMessages(messages []*sarama.ProducerMessage) r.Tes
kafkaConfig.Producer.Return.Errors = true
kafkaConfig.Producer.Return.Successes = true
kafkaConfig.Producer.RequiredAcks = sarama.WaitForAll
kafkaConfig.Producer.Timeout = 90 * time.Second

producer, err := sarama.NewSyncProducer(*config.BootstrapServers, kafkaConfig)
if err != nil {
Expand Down

0 comments on commit 52876a8

Please sign in to comment.