Fix position/orientation results #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GerhardHippmann
commented
Nov 22, 2023
GerhardHippmann
commented
- Enable position and orientation result signals for all user-defined Object3Ds, independently of visualisation/animation configuration
- Replace orientation result matrix R_abs -> Cardan angles rot123_abs
- Enable position and orientation result signals for all user-defined Object3Ds, independently of visualisation/animation configuration - Replace orientation result matrix R_abs -> Cardan angles rot123_abs
Comment on lines
+646
to
+652
| function isVisible(obj::Object3D{F})::Bool where F <: Modia3D.VarFloatType | ||
| if isSolid(obj) || isVisual(obj) | ||
| return !isnothing(obj.feature.visualMaterial) && !isnothing(obj.feature.shape) | ||
| else | ||
| return false | ||
| end | ||
| end |
There was a problem hiding this comment.
Please, check if a default return type is needed outside of if/else with (code_warntype).
There was a problem hiding this comment.
'code_warntype' does not report an issue with the explicitly defined return type 'Bool'.
| @@ -436,8 +436,8 @@ end | |||
|
|
|||
|
|
|||
| function exportAnimation(scene) | |||
There was a problem hiding this comment.
Please, define return type and scene::Scene{F} in function.
|
@AndreaNeumayr Bug in dependencies has been fixed. So from my point of view we can release now. Please do not forget to update release notes, version numbers and dates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.