QA

MobSF · Nov 29, 2024 · 772c6c9 · 772c6c9
1 parent 8a5ea49
commit 772c6c9
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 8 deletions.
diff --git a/mobsf/StaticAnalyzer/views/android/aapt.py b/mobsf/StaticAnalyzer/views/android/aapt.py
@@ -47,7 +47,7 @@ def __init__(self, apk_path):
         else:
             self.aapt_path = find_aapt('aapt')
 
-        # Ensure at least one tool is available
+        # Ensure both aapt and aapt2 are found
         if not (self.aapt2_path and self.aapt_path):
             raise FileNotFoundError('aapt and aapt2 found')
 

diff --git a/mobsf/StaticAnalyzer/views/android/manifest_utils.py b/mobsf/StaticAnalyzer/views/android/manifest_utils.py
@@ -170,7 +170,7 @@ def get_parsed_manifest(app_dic):
 def extract_manifest_data(app_dic):
     """Extract manifest data.
 
-    Backup data from apk_features (aapt2) if not found in manifest.
+    Data from apk_features (aapt2) is also available as a fallback.
     """
     checksum = app_dic['md5']
     try:

diff --git a/mobsf/templates/base/base_layout.html b/mobsf/templates/base/base_layout.html
@@ -26,6 +26,16 @@
     body {
       zoom: 0.8; 
     }
+    .modal-backdrop {
+      position: fixed;
+      top: 0;
+      left: 0;
+      width: 100%;
+      height: 100%;
+      z-index: 1040; /* Ensure it is above most elements but below modal */
+      background-color: rgba(0, 0, 0, 0.5); /* Default backdrop color */
+    }
+
   </style>
   {% block extra_css %}
 

diff --git a/mobsf/templates/static_analysis/android_binary_analysis.html b/mobsf/templates/static_analysis/android_binary_analysis.html
@@ -2557,11 +2557,13 @@ <h4 class="modal-title">Suppression Rules</h4>
 {% endblock %}
 {% block scan_logs %}
 <table id="scan_logs" class="table table-bordered table-hover table-striped">
+  <thead>
     <tr>
         <th>Timestamp</th>
         <th>Event</th>
         <th>Error</th>
     </tr>
+  </thead>
 <tbody>
   {% for log in logs %}
   <tr>

diff --git a/mobsf/templates/static_analysis/android_source_analysis.html b/mobsf/templates/static_analysis/android_source_analysis.html
@@ -1944,11 +1944,13 @@ <h4 class="modal-title">Suppression Rules</h4>
 {% endblock %}
 {% block scan_logs %}
 <table id="scan_logs" class="table table-bordered table-hover table-striped">
+  <thead>
     <tr>
         <th>Timestamp</th>
         <th>Event</th>
         <th>Error</th>
     </tr>
+  </thead>
 <tbody>
   {% for log in logs %}
   <tr>

diff --git a/mobsf/templates/static_analysis/ios_binary_analysis.html b/mobsf/templates/static_analysis/ios_binary_analysis.html
@@ -1921,12 +1921,14 @@ <h4 class="modal-title">Suppression Rules</h4>
 {% endblock %}
 {% block scan_logs %}
 <table id="scan_logs" class="table table-bordered table-hover table-striped">
-    <tr>
-        <th>Timestamp</th>
-        <th>Event</th>
-        <th>Error</th>
-    </tr>
-<tbody>
+ <thead>
+  <tr>
+      <th>Timestamp</th>
+      <th>Event</th>
+      <th>Error</th>
+  </tr>
+ </thead>
+ <tbody>
   {% for log in logs %}
   <tr>
     <td>

diff --git a/mobsf/templates/static_analysis/ios_source_analysis.html b/mobsf/templates/static_analysis/ios_source_analysis.html
@@ -1392,11 +1392,13 @@ <h4 class="modal-title">Suppression Rules</h4>
 {% endblock %}
 {% block scan_logs %}
 <table id="scan_logs" class="table table-bordered table-hover table-striped">
+  <thead>
     <tr>
         <th>Timestamp</th>
         <th>Event</th>
         <th>Error</th>
     </tr>
+  </thead>
 <tbody>
   {% for log in logs %}
   <tr>

diff --git a/mobsf/templates/static_analysis/windows_binary_analysis.html b/mobsf/templates/static_analysis/windows_binary_analysis.html
@@ -463,11 +463,13 @@ <h4 class="modal-title">Strings</h4>
 {% endblock %}
 {% block scan_logs %}
 <table id="scan_logs" class="table table-bordered table-hover table-striped">
+   <thead>
     <tr>
         <th>Timestamp</th>
         <th>Event</th>
         <th>Error</th>
     </tr>
+  </thead>
 <tbody>
   {% for log in logs %}
   <tr>