Code QA

MobSF · Dec 6, 2023 · 6434d0b · 6434d0b
1 parent 6e03370
commit 6434d0b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/mobsf/DynamicAnalyzer/views/android/frida_core.py b/mobsf/DynamicAnalyzer/views/android/frida_core.py
@@ -147,6 +147,7 @@ def spawn(self):
         except frida.TimedOutError:
             logger.error('Timed out while waiting for device to appear')
         except (frida.ProcessNotFoundError,
+                frida.ProcessNotRespondingError,
                 frida.TransportError,
                 frida.InvalidOperationError):
             pass
@@ -184,6 +185,7 @@ def session(self, pid, package):
         except frida.NotSupportedError:
             logger.exception('Not Supported Error')
         except (frida.ProcessNotFoundError,
+                frida.ProcessNotRespondingError,
                 frida.TransportError,
                 frida.InvalidOperationError):
             pass

diff --git a/mobsf/DynamicAnalyzer/views/ios/frida_core.py b/mobsf/DynamicAnalyzer/views/ios/frida_core.py
@@ -54,8 +54,8 @@ def __init__(
         self.dump_file = self.ipa_dir / 'mobsf_dump_file.txt'
         self.container_file = self.ipa_dir / 'mobsf_app_container_path.txt'
         self.not_supported_text = (
-            'Failed to instrument the app with Frida.'
-            'This app is not supported by Frida.'
+            'Failed to instrument the app with Frida. '
+            'This app is not supported by Frida. '
             'Are you able to run the app on '
             'this device?')
 
@@ -178,6 +178,7 @@ def spawn(self):
             logger.error(self.not_supported_text)
             return
         except (frida.ProcessNotFoundError,
+                frida.ProcessNotRespondingError,
                 frida.TransportError,
                 frida.InvalidOperationError):
             pass
@@ -222,6 +223,7 @@ def session(self, pid, bundle_id):
         except frida.NotSupportedError:
             logger.error(self.not_supported_text)
         except (frida.ProcessNotFoundError,
+                frida.ProcessNotRespondingError,
                 frida.TransportError,
                 frida.InvalidOperationError):
             pass

diff --git a/mobsf/templates/dynamic_analysis/android/dynamic_analyzer.html b/mobsf/templates/dynamic_analysis/android/dynamic_analyzer.html
@@ -1266,7 +1266,6 @@ <h4 class="modal-title">Run TLS/SSL Security Tests - {{ package }}</h4>
         $('#frida_attach_mdl').modal('toggle');
       } else if (frida_action =='get'){
         var injected = document.getElementById("injected_content");
-        injected.innerHTML = '';
         injected.innerHTML = '<pre id="injected-pre"></pre>';
         document.getElementById("injected-pre").textContent = json.message;
         EnlighterJS.enlight( document.getElementById('injected-pre'), {

diff --git a/mobsf/templates/dynamic_analysis/ios/dynamic_analyzer.html b/mobsf/templates/dynamic_analysis/ios/dynamic_analyzer.html
@@ -1029,6 +1029,7 @@ <h5 class="modal-title" id="exampleModalLabel">Attach to a Running Process</h5>
         print_status('Runnning application');
     } else {
         print_status('Failed to run the application');
+        Swal.fire('Failed!', escape(json.message), 'error')
     }
   });
   return false;  
@@ -1117,7 +1118,6 @@ <h5 class="modal-title" id="exampleModalLabel">Attach to a Running Process</h5>
           $('#frida_attach_mdl').modal('toggle');
         } else if (frida_action =='get'){
           var injected = document.getElementById("injected_content");
-          injected.innerHTML = '';
           injected.innerHTML = '<pre id="injected-pre"></pre>';
           document.getElementById("injected-pre").textContent = json.message;
           EnlighterJS.enlight( document.getElementById('injected-pre'), {