ready to merge

include/json.hpp

@@ -96,15 +96,14 @@ class basic_value
     template <typename... args_t>
     basic_value(value_type type, args_t&&... args);
 
-    // Prohibit conversion of other types to basic_value
     template <typename value_t, typename _ = std::enable_if_t<!std::is_convertible_v<value_t, basic_value<string_t>>>>
     basic_value(value_t) = delete;
 
+    // I don't know if you want to convert char to string or number, so I delete these constructors.
     basic_value(char) = delete;
-    basic_value(unsigned char) = delete;
+    basic_value(wchar_t) = delete;
     basic_value(char16_t) = delete;
     basic_value(char32_t) = delete;
-    basic_value(wchar_t) = delete;
 
     ~basic_value();
 

sample/sample.cpp

@@ -245,9 +245,9 @@ bool serializing()
         { { "i", "am", "key1" }, { { 1, { 0.1, 0.2 } }, { 2, { 0.2, 0.3 } } } },
         { { "key2" }, { { 3, { 0.4 } }, { 4, { 0.5, 0.6, 0.7 } } } },
     };
-    // the "std::map<int, xxx>" cannot be converted to json because the key is "int",
+    // the "std::map" cannot be converted to json because the key is "std::vector<std::string>",
     // you can set the template parameter "loose" of "serialize" to true, which will make a more relaxed conversion.
-    json::value crazy_serialization = json::serialize<true>(more_complex);
+    root["more_complex"] = json::serialize<true>(more_complex);
 
     // for test
     root["a\\n"] = "1a\\n";