Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge compatible to develop 13 01 25 #16462

Open
wants to merge 79 commits into
base: develop
Choose a base branch
from
Open

merge compatible to develop 13 01 25 #16462

wants to merge 79 commits into from

Conversation

dkijania
Copy link
Member

merge compatible to develop 13 01 25

georgeee and others added 30 commits December 5, 2024 11:32
@georgeee
Remove constraint_constants from currency_consumed
9937554 
This parameter is not used.
@svv232
removing compile time config load logging from cli
e824170
@svv232
fixing loading in all of the apps to fix CI
63a8ce7
@svv232
fixing unit test builds
8ea10e5
@svv232
remove logger and fixing build for mina lib
5aa527c
@svv232
only propogate a logger when one already exists
0880b79
@svv232
remove unecessary logger invocation
2d22bc1
@svv232
adding logger back to apps while loading json config
85634a1
@svv232
format the client
2efdc28
@svv232
add load_constants_with_logging definition and use the definition in …
2f8fa03 
…snark functor and apps
@mrmr1993
Update snarky for removed 'field parameter
261ee46
@mrmr1993
Update snarky for further-refined types
7a1ff2c
@mrmr1993
Bump snarky for more abstraction changes
bc75f95
@dkijania
Print verification keys
bf4e23b
@dkijania
Merge pull request #16029 from MinaProtocol/dkijania/use_new_apt_repo
c052db3 
add option to use new debian repo
@mrmr1993
Remove now-unnecessary parameter ~constraint_constants
f1436d4
@mrmr1993
Fixup heap_usage app
2b63e8c
@mrmr1993
Merge pull request #16446 from MinaProtocol/feature/remove-constraint…
d3f9e39 
…-constants-pickles-compile

Remove now-unnecessary `Pickles.compile` parameter `~constraint_constants`
@mrmr1993
Merge pull request #16399 from MinaProtocol/georgeee/remove-constrain…
390fb30 
…t_constants-from-currency_consumed

Remove constraint_constants from currency_consumed
@mrmr1993
Merge pull request #16433 from MinaProtocol/feature/further-simplifie…
4c5c342 
…d-snarky-typ

Simplify snarky `Typ.t`, removing unnecessary type parameters
@dkijania
Merge pull request #16437 from MinaProtocol/dkijania/print_key_sizes_…
2b69f3f 
…in_disk_caching_stats

Print key sizes in disk_caching_stats
@mrmr1993
Update snarky to remove Checked.Simple
e1a6ed4
@mrmr1993
Include Run_state in snarky backend
ffebab1
@mrmr1993
Update snarky to remove unused ~label argument
3519a59
@mrmr1993
Add constraint_ to Plonk_constraint_system
b624b65
@mrmr1993
Use concretized snarky Run_state.t
2788bcb
@mrmr1993
Hoist Constraint.t declaration into Plonk_constraint_system
3e20b80
@mrmr1993
Use functored Run_state from snarky
435bacd
@mrmr1993
Specialize constraint
0ea9c42
@dkijania
revert removal of joins for accounts_created
380c0e1
dannywillems and others added 20 commits January 8, 2025 10:29
@dannywillems
Run make reformat for scalar_challenge.mli
36832f2
@dannywillems
Pickles_base: remove ignored warning 40-42
35c469a
@dannywillems
Merge pull request #16450 from MinaProtocol/feature/specalize-cvars
de1f5e0 
Tidy up some pickles interfaces
@dannywillems
Merge branch 'compatible' into feature/specialize-types
3ee1b2e
@dkijania
remove duplicated verifier
dbc1ba0
@dkijania
Merge pull request #16454 from MinaProtocol/dkijania/reorg_transactio…
40c86e2 
…n_pool_tests

refactor network tests
@georgeee
Merge pull request #16403 from MinaProtocol/sai/removing-logging-from…
c3c7c34 
…-cfg-loading

removing compile time config load logging from cli
@dkijania
add more tests for mina cli. Mostly simple commands which historicall…
aae6a81 
…y had issues with printing out junky log on output
@dannywillems
Merge pull request #16452 from MinaProtocol/feature/specialize-types
2e2a415 
Specialize pickles types instead of using snarky's `Cvar.t`s
@dannywillems
Merge branch 'compatible' into feature/generalize-cvar-for-real
2fb104c
@dannywillems
Merge branch 'compatible' into dw/proof-verified-remove-ignore-warning
64d62b4
@dkijania
fix expected length for ledger hash
49b8295
@mrmr1993
Merge pull request #16455 from MinaProtocol/dw/proof-verified-remove-…
049e80b 
…ignore-warning

Pickles_base: remove ignored warning 40-42
@dkijania
Revert "Merge pull request #16454 from MinaProtocol/dkijania/reorg_tr…
2a44804 
…ansaction_pool_tests"

This reverts commit 40c86e2, reversing
changes made to de1f5e0.
@dkijania
Merge pull request #16461 from MinaProtocol/dkijania/revert_network_t…
c3715a7 
…ests_refactoring

Revert transaction pool reorganization
@dkijania
Merge pull request #16447 from MinaProtocol/dkijania/fix_indexer_tests
e6e9601 
Fix indexer test
@dkijania
Merge pull request #16402 from MinaProtocol/dkijania/add_more_mina_cl…
59eff67 
…i_tests

add e2e tests for mina cli (unexpected log output)
@mrmr1993
Rename field variable to 'f
1501dc1
@mrmr1993
Merge pull request #16453 from MinaProtocol/feature/generalize-cvar-f…
3ebfd0a 
…or-real

Generalize pickles and snarky utils over field variable type
@dkijania
Merge branch 'compatible' into dkijania/merge/compatible_to_develop_1…
637cc0c 
…3_01_25
@dkijania dkijania self-assigned this Jan 13, 2025
@dkijania dkijania marked this pull request as ready for review January 13, 2025 15:53
@dkijania dkijania requested review from a team as code owners January 13, 2025 15:53
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-nightly-me

@coveralls
Copy link

Coverage Status

coverage: 36.146% (-24.4%) from 60.578%
when pulling 637cc0c on dkijania/merge/compatible_to_develop_13_01_25
into a0a2adf on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanabriaRusso SanabriaRusso SanabriaRusso approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@dkijania dkijania

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dkijania @coveralls @SanabriaRusso @georgeee @svv232 @mrmr1993 @dannywillems