Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proof-systems #14549

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Update proof-systems #14549

merged 7 commits into from
Nov 21, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Nov 13, 2023 •
edited
Loading

Explain your changes:

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner November 13, 2023 15:09
@dannywillems dannywillems mentioned this pull request Nov 13, 2023
Merged
@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993
Copy link
Member

!ci-nightly-me

@volhovm
Copy link
Member

volhovm commented Nov 16, 2023

!ci-build-me

@volhovm volhovm requested a review from a team as a code owner November 16, 2023 18:39
@dannywillems
Copy link
Member Author

!ci-build-me

This was referenced Nov 17, 2023
Merged
Merged
@volhovm
Copy link
Member

volhovm commented Nov 18, 2023

!ci-build-me

1 similar comment
@volhovm
Copy link
Member

volhovm commented Nov 18, 2023

!ci-build-me

@volhovm
Copy link
Member

volhovm commented Nov 18, 2023

!ci-build-me

@dannywillems dannywillems merged commit 78535ae into develop Nov 21, 2023
2 checks passed
@dannywillems dannywillems deleted the dannywillems/update-proof-systems-to-new-lookup branch November 21, 2023 13:49
mrmr1993 added a commit that referenced this pull request Dec 4, 2023
@mrmr1993
Revert "Merge pull request #14549 from MinaProtocol/dannywillems/upda…
181fe27 
…te-proof-systems-to-new-lookup"

This reverts commit 78535ae, reversing
changes made to 5528528.
@mrmr1993 mrmr1993 mentioned this pull request Dec 4, 2023
Merged
7 tasks
@mitschabaude mitschabaude mentioned this pull request Dec 19, 2023
Closed
@mitschabaude mitschabaude mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

@volhovm volhovm volhovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dannywillems @mrmr1993 @volhovm @mitschabaude