Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs, examples): change hash() method to hash property #877

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Mar 4, 2024

Merge once o1-labs/o1js#1422 is released

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 6:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 6:28pm

@MartinMinkov MartinMinkov linked an issue Mar 4, 2024 that may be closed by this pull request
@MartinMinkov MartinMinkov marked this pull request as ready for review March 4, 2024 23:49
@MartinMinkov MartinMinkov requested a review from a team as a code owner March 4, 2024 23:49
Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating all of this.

…atus for transaction status check

refactor(interact.ts, main.ts, utils.ts): replace isSuccess with status for transaction status validation
feat(interacting-with-zkapps-server-side.mdx): enhance explanation of pendingTransaction properties
refactor(interacting-with-zkApps-server-side): update isSuccess to status for transaction status check
@MartinMinkov MartinMinkov merged commit 7ee778a into main Mar 6, 2024
4 checks passed
@MartinMinkov MartinMinkov deleted the feat/local-parity-fixes branch March 6, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Server side tutorial transaction.hash() updates
2 participants