Use pathlib in smoke tests and setup.py (#620)

setup.py

@@ -5,12 +5,13 @@
 import sys
 import shutil
 import subprocess as sp
+from pathlib import Path
 
 # monkey patch because setuptools entry_points are slow as fuck
 # https://github.com/ninjaaron/fast-entry_points
 import fastentrypoints  # pylint: disable=unused-import
 
-HERE = os.path.abspath(os.path.dirname(__file__))
+HERE = Path(__file__).absolute().parent
 
 
 def activate_argcomplete():
@@ -49,7 +50,7 @@ def finalize_options(self):
     def run(self):
         try:
             print("Removing previous dist/ ...")
-            shutil.rmtree(os.path.join(HERE, "dist"))
+            shutil.rmtree(HERE / "dist")
         except OSError:
             pass
         print("Building source distribution...")
@@ -68,7 +69,7 @@ def run(self):
     author_email="[email protected]",
     url="https://github.com/MichaelGrupp/evo",
     license="GPLv3",
-    long_description=open(os.path.join(HERE, "README.md")).read(),
+    long_description=open(HERE / "README.md").read(),
     long_description_content_type="text/markdown",
     keywords=[
         "SLAM", "odometry", "trajectory", "evaluation", "metric",

test/ape_rpe_smoke_test.py

@@ -3,10 +3,11 @@
 import os
 import shutil
 import subprocess as sp
+from pathlib import Path
 
-tmp_dir = "tmp"
-cfg_dir = "cfg/ape_rpe"
-here = os.path.dirname(os.path.abspath(__file__))
+tmp_dir = Path("tmp")
+cfg_dir = Path("cfg/ape_rpe")
+here = Path(__file__).absolute().parent
 
 # always run in script location
 os.chdir(here)
@@ -23,9 +24,8 @@
 try:
     for m in metrics:
         for d in data:
-            for cfg in os.listdir(cfg_dir):
-                os.mkdir(tmp_dir)
-                cfg = os.path.join(cfg_dir, cfg)
+            for cfg in cfg_dir.iterdir():
+                tmp_dir.mkdir(exist_ok=True)
                 cmd = "{} {} -c {}".format(m, d, cfg)
                 print("[smoke test] {}".format(cmd))
                 output = sp.check_output(cmd.split(" "), cwd=here)
@@ -34,5 +34,5 @@
     print(e.output.decode("utf-8"))
     raise
 finally:
-    if os.path.exists(tmp_dir):
+    if tmp_dir.exists():
         shutil.rmtree(tmp_dir)

test/res_smoke_test.py

@@ -3,10 +3,11 @@
 import os
 import shutil
 import subprocess as sp
+from pathlib import Path
 
-tmp_dir = "tmp"
-cfg_dir = "cfg/res"
-here = os.path.dirname(os.path.abspath(__file__))
+tmp_dir = Path("tmp")
+cfg_dir = Path("cfg/res")
+here = Path(__file__).absolute().parent
 
 # always run in script location
 os.chdir(here)
@@ -19,9 +20,8 @@
 
 try:
     for d in data:
-        for cfg in os.listdir(cfg_dir):
-            os.mkdir(tmp_dir)
-            cfg = os.path.join(cfg_dir, cfg)
+        for cfg in cfg_dir.iterdir():
+            tmp_dir.mkdir(exist_ok=True)
             cmd = "evo_res {} -c {}".format(d, cfg)
             print("[smoke test] {}".format(cmd))
             output = sp.check_output(cmd.split(" "), cwd=here)
@@ -30,5 +30,5 @@
     print(e.output.decode("utf-8"))
     raise
 finally:
-    if os.path.exists(tmp_dir):
+    if tmp_dir.exists():
         shutil.rmtree(tmp_dir)

test/traj_smoke_test.py

@@ -4,10 +4,11 @@
 import glob
 import shutil
 import subprocess as sp
+from pathlib import Path
 
-tmp_dir = "tmp"
-common_cfg_dir = "cfg/traj/common"
-here = os.path.dirname(os.path.abspath(__file__))
+tmp_dir = Path("tmp")
+common_cfg_dir = Path("cfg/traj/common")
+here = Path(__file__).absolute().parent
 
 # always run in script location
 os.chdir(here)
@@ -23,10 +24,9 @@
 
 try:
     for d in data.keys():
-        for cfg_dir in (common_cfg_dir, data[d]):
-            for cfg in os.listdir(cfg_dir):
-                os.mkdir(tmp_dir)
-                cfg = os.path.join(cfg_dir, cfg)
+        for cfg_dir in (common_cfg_dir, Path(data[d])):
+            for cfg in cfg_dir.iterdir():
+                tmp_dir.mkdir(exist_ok=True)
                 cmd = "{} -c {}".format(d, cfg)
                 print("[smoke test] {}".format(cmd))
                 output = sp.check_output(cmd.split(" "), cwd=here)
@@ -39,5 +39,5 @@
         "./*.tum")
     for traj_file in traj_files:
         os.remove(traj_file)
-    if os.path.exists(tmp_dir):
+    if tmp_dir.exists():
         shutil.rmtree(tmp_dir)