Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed userIsInRole to be async #391

Closed
wants to merge 1 commit into from

Conversation

dallman2
Copy link

@dallman2 dallman2 commented Mar 6, 2024

for use with the open version 4 pr

@dallman2
Copy link
Author

dallman2 commented Mar 7, 2024

Just checked out the reason the tests are failing. All of the tests seem to not expect this method to be async, which makes sense. Is there any larger effort underway to remake the tests to be async?

@StorytellerCZ
Copy link
Member

I've checked and I think there is a bit of a misunderstanding here. We already have the async version of this function in roles_common_async. I guess the next step is that the current roles_common will become just roles_client in v4 as on server we will only be able to use async.

@dallman2
Copy link
Author

dallman2 commented Mar 7, 2024

That makes a lot of sense. I will clone the current pr for v4 and see if i can get it running locally using the async stuff you referenced

@dallman2 dallman2 closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants