Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 278.0.0 #5126

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Release 278.0.0 #5126

merged 6 commits into from
Jan 10, 2025

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Jan 10, 2025

Explanation

  • fix(3742): improve user segmentation with BigInt-based random generation (#5110)
  • fix(3742): change getMetaMetricsId to only sync func type (#5108)

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@DDDDDanica DDDDDanica self-assigned this Jan 10, 2025
### Changed

- fix(3742): improve user segmentation with BigInt-based random generation ([#5110](https://github.com/MetaMask/core/pull/5110))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the fix(3742) prefixes here? We don't use category prefixes, since we have headers instead. And it's a bit confusing to have this described as a fix given that it hasn't been categorized as such

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely ! good catch ! removed in 810d7ee

Copy link

@joaoloureirop joaoloureirop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DDDDDanica DDDDDanica merged commit 9c4146d into main Jan 10, 2025
120 checks passed
@DDDDDanica DDDDDanica deleted the release/278.0.0 branch January 10, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants