Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-30339 #288

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

LPD-30339 #288

wants to merge 7 commits into from

Conversation

MarinhoFeliphe
Copy link
Owner

No description provided.

# breaking

## What modules/apps/object/object-api/src/main/java/com/liferay/object/service/ObjectActionLocalService.java

Adding parameters boolean usePreferredLocaleForGuests changing its signature from

	public ObjectAction addObjectAction(
			String externalReferenceCode, long objectDefinitionId,
			boolean active, String conditionExpression, String description,
			Map<Locale, String> errorMessageMap, Map<Locale, String> labelMap,
			String name, String objectActionExecutorKey,
			String objectActionTriggerKey,
			UnicodeProperties parametersUnicodeProperties, boolean system)
		throws PortalException;

    to

	public ObjectAction addObjectAction(
			String externalReferenceCode, long objectDefinitionId,
			boolean active, String conditionExpression, String description,
			Map<Locale, String> errorMessageMap, Map<Locale, String> labelMap,
			String name, String objectActionExecutorKey,
			String objectActionTriggerKey,
			UnicodeProperties parametersUnicodeProperties, boolean system,
			boolean usePreferredLocaleForGuests)
		throws PortalException;

## Why

Provide a way to use the preferred locale when guests trigger object actions that perform an operation that requires a locale.

----

# breaking

## What modules/apps/object/object-api/src/main/java/com/liferay/object/service/ObjectActionService.java

Adding parameters boolean usePreferredLocaleForGuests changing its signature from

	public ObjectAction addObjectAction(
			String externalReferenceCode, long objectDefinitionId,
			boolean active, String conditionExpression, String description,
			Map<Locale, String> errorMessageMap, Map<Locale, String> labelMap,
			String name, String objectActionExecutorKey,
			String objectActionTriggerKey,
			UnicodeProperties parametersUnicodeProperties, boolean system)
		throws PortalException;

    to

	public ObjectAction addObjectAction(
			String externalReferenceCode, long objectDefinitionId,
			boolean active, String conditionExpression, String description,
			Map<Locale, String> errorMessageMap, Map<Locale, String> labelMap,
			String name, String objectActionExecutorKey,
			String objectActionTriggerKey,
			UnicodeProperties parametersUnicodeProperties, boolean system,
			boolean usePreferredLocaleForGuests)
		throws PortalException;

## Why

Provide a way to use the preferred locale when guests trigger object actions that perform an operation that requires a locale.

----
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants