MDBF-883 - CentOS 7 bintar compatibility with old buildbot #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the MDBF, I am preparing several (manual) changes to the centos-7-bintar container image, one of which will bump GnuTLS version to 3.7.x, as in buildbot.mariadb.net GNUTLS_NO_SIGNAL flag was introduced in GnuTLS 3.4.x so there's no need to disable the macro anymore. (the flag is not present in buildbot.mariadb.net) More on that, from my tests (10.11), disabling the macro will cause the compilation to fail when using the newer GnuTLS (static library). <command-line>:0:18: error: expected identifier before numeric constant. Important notes: This code change should only be deployed in Production when the updated centos7-bintar is published in quay, in this order: - deploy code changes - stop master-docker-nonstandard (where the builder is defined) - update image on quay - start master-docker-nonstandard I will probably deploy this change manually because there are some pending other changes which need to be tested and given the BLOCKER status of the MDBF, it should be deployed ASAP.
grooverdan
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the MDBF, I am preparing several (manual) changes to the
centos-7-bintarcontainer image, one of which will bumpGnuTLS version to 3.7.x,as inbuildbot.mariadb.netGNUTLS_NO_SIGNALflag was introduced inGnuTLS 3.4.xso there's no need to disable the macro anymore. (the flag is not present in buildbot.mariadb.net configuration)More on that, from my tests << 10.11 >> (thanks @cvicentiu for help) disabling the macro will cause the compilation to fail when using the newer GnuTLS (static library).
<command-line>:0:18: error: expected identifier before numeric constant.Important notes:
This code change should only be deployed in Production when the updated
centos7-bintaris published in quay, in this order:I will probably deploy this change manually because there are some pending
other changes which need to be tested and given the BLOCKER
status of the MDBF, it should be deployed ASAP.