Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env ENVIRON as DEV/PROD differenciator #232

Merged
merged 1 commit into from
Nov 3, 2023
Merged

env ENVIRON as DEV/PROD differenciator #232

merged 1 commit into from
Nov 3, 2023

Conversation

grooverdan
Copy link
Member

Just a concept for making some stuff DEV only.

requires ENVIRON to be set in the master-private.cfg

@fauust
Copy link
Collaborator

fauust commented Nov 1, 2023 •
edited
Loading

Just a concept for making some stuff DEV only.

requires ENVIRON to be set in the master-private.cfg

Daniel, no need to touch the master-private.cfg file, just add the variables that you need in https://github.com/MariaDB/buildbot/blob/dev/docker-compose/.env.dev or https://github.com/MariaDB/buildbot/blob/dev/docker-compose/.env, they will be available in any container ;)

See also: https://github.com/MariaDB/buildbot/blob/dev/.github/workflows/bbm_deploy.yml#L67

@grooverdan grooverdan enabled auto-merge (rebase) November 2, 2023 00:07
@grooverdan grooverdan merged commit 7962a74 into MariaDB:dev Nov 3, 2023
3 checks passed
@grooverdan grooverdan deleted the devonly branch November 6, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbogo vladbogo vladbogo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grooverdan @fauust @vladbogo